chore: git fixes - removing beta tag by brayn003 · Pull Request #39733 · appsmithorg/appsmith

brayn003 · 2025-03-14T10:51:40Z

Description

Removes beta tag for connect button
Removes beta tag from the "Import via Git" card
Removes beta flags only when release_git_modularisation_enabled is false

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13855553055
Commit: 166d347
Cypress dashboard.
Tags: @tag.Git
Spec:

Fri, 14 Mar 2025 12:18:24 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

New Features
- The “Import from Git repository” messaging now adapts dynamically to indicate whether the feature is in beta.
- New quick action messages introduced for Git connection options.
- The Git Import modal title now adjusts based on the current integration status.
Refactor
- Consolidated Git-related message handling for a more streamlined user interface.

…git-fixes-1

coderabbitai · 2025-03-14T10:51:49Z

Walkthrough

The changes refactor Git-related message handling across multiple components. In the CE constants file, a static Git import title is replaced with a function that accepts a beta flag, and an unused Git connection constant is removed. In the Git module, a new QUICK_ACTIONS object is introduced to consolidate several message constants, and the ConnectButton component is updated to use these messages. Additionally, the ImportModal now derives the Git module state from a hook to dynamically adjust its title message.

Changes

File(s)	Change Summary
`app/client/src/ce/constants/messages.ts`	Refactored `IMPORT_APP_FROM_GIT_TITLE` to a function with an `isBeta` parameter; removed the `CONNECT_GIT` constant.
`app/client/src/git/ce/constants/messages.tsx` `app/client/src/git/components/QuickActions/ConnectButton.tsx`	Introduced a new `QUICK_ACTIONS` constant for Git messages; removed multiple obsolete message constants and helper functions; updated ConnectButton to use messages from `QUICK_ACTIONS`.
`app/client/src/pages/common/ImportModal.tsx`	Added a new variable `isGitModEnabled` derived from a hook, modifying the title generation logic for the Git import card by negating the flag in the message creation process.

Sequence Diagram(s)

sequenceDiagram
    participant Modal as ImportModal
    participant Hook as useGitModEnabled
    participant Message as createMessage
    Modal->>Hook: Call useGitModEnabled()
    Hook-->>Modal: Return isGitModEnabled
    Modal->>Message: Call createMessage(..., !isGitModEnabled)
    Message-->>Modal: Return Git import title

sequenceDiagram
    participant User
    participant Button as ConnectButton
    participant Msg as QUICK_ACTIONS
    User->>Button: Hover/Click
    Button->>Msg: Retrieve tooltip and button text
    Msg-->>Button: Return corresponding message
    Button->>User: Display updated message

Possibly related PRs

fix: fixing cta for git import modal #36364: The changes in the main PR, which modify the IMPORT_APP_FROM_GIT_TITLE constant, are related to the retrieved PR as both involve updates to constants in the messages.ts file, specifically enhancing user messaging for Git import functionality.
chore: beta tags enabled for certain integrations #39489: The changes in the main PR, which involve modifying the IMPORT_APP_FROM_GIT_TITLE constant in app/client/src/ce/constants/messages.ts, are related to the retrieved PR's addition of the BETA_TAG function in the same file, as both involve updates to constants that handle beta feature messaging.

Suggested labels

Bug, Enhancement, Packages & Git Pod

Suggested reviewers

ApekshaBhosale
ashit-rath

Poem

In the code’s quiet night, a tweak does gleam,
Beta flags now whisper, like a smart dream.
Constants rearranged, old ones swept away,
Quick actions shine bright in their new display.
Git flows refreshed—a merry dance in view.
Celebrate this change with a cheer anew!
🚀✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 9d70a77 and 166d347.

📒 Files selected for processing (1)

app/client/src/git/components/QuickActions/ConnectButton.test.tsx (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: perform-test / client-build / client-build
GitHub Check: perform-test / rts-build / build
GitHub Check: perform-test / server-build / server-unit-tests
GitHub Check: client-lint / client-lint
GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
GitHub Check: client-unit-tests / client-unit-tests
GitHub Check: client-build / client-build
GitHub Check: client-prettier / prettier-check

🔇 Additional comments (4)

app/client/src/git/components/QuickActions/ConnectButton.test.tsx (4)

67-67: Test updated to reflect removal of beta tag.

The test case is correctly updated to match the new button text without the "Beta" label.

94-94: Button label updated consistently across test cases.

This change maintains consistency with the updated ConnectButton implementation.

104-104: Tooltip message updated to use "artifact" instead of "app".

The terminology change from "app" to "artifact" aligns with the broader application terminology updates.

121-121: Beta label removed from button name in final test case.

All test assertions have been consistently updated to reflect the non-beta status.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

## Description - Removes beta tag for connect button - Removes beta tag from the "Import via Git" card - Removes beta flags only when `release_git_modularisation_enabled` is false Fixes appsmithorg#30110 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13855553055> > Commit: 166d347 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13855553055&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Fri, 14 Mar 2025 12:18:24 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - The “Import from Git repository” messaging now adapts dynamically to indicate whether the feature is in beta. - New quick action messages introduced for Git connection options. - The Git Import modal title now adjusts based on the current integration status. - **Refactor** - Consolidated Git-related message handling for a more streamlined user interface.

Rudraprasad Das added 2 commits March 14, 2025 11:48

chore: git fixes - remove beta tag

d4fe86c

Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…

9d70a77

…git-fixes-1

github-actions bot added Git Platform Issues related to the git & the app platform Git Product Issues related to version control product Task A simple Todo skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Mar 14, 2025

brayn003 added the ok-to-test Required label for CI label Mar 14, 2025

ashit-rath previously approved these changes Mar 14, 2025

View reviewed changes

chore: fixing unit tests

166d347

brayn003 dismissed ashit-rath’s stale review via 166d347 March 14, 2025 11:23

brayn003 self-assigned this Mar 14, 2025

ashit-rath approved these changes Mar 14, 2025

View reviewed changes

brayn003 merged commit 1835e05 into release Mar 14, 2025
46 checks passed

brayn003 deleted the chore/git-fixes-1 branch March 14, 2025 12:27

This was referenced Mar 18, 2025

chore: remove anvil flag for git #39785

Merged

fix: making import messaging artifact agnostic #39869

Merged

coderabbitai bot mentioned this pull request Mar 31, 2025

chore: git tag - adding ui improvments #39972

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: git fixes - removing beta tag#39733

chore: git fixes - removing beta tag#39733
brayn003 merged 3 commits intoreleasefrom
chore/git-fixes-1

brayn003 commented Mar 14, 2025 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Mar 14, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

brayn003 commented Mar 14, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

brayn003 commented Mar 14, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Mar 14, 2025 •

edited

Loading